Skip to content

fix(site): wait until port is available in e2e #15537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 18, 2024
Merged

fix(site): wait until port is available in e2e #15537

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
755c925
fix(site): e2e: wait until port is available)
mtojek Nov 15, 2024
216af9c
errno
mtojek Nov 15, 2024
0843a8f
fmt
mtojek Nov 15, 2024
444baad
Expanding timeout, fixing retry interval
dannykopping Nov 18, 2024
cdd9d8b
make fmt
dannykopping Nov 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Expanding timeout, fixing retry interval 
Signed-off-by: Danny Kopping <danny@coder.com>
  • Loading branch information
@dannykopping
dannykopping committed Nov 18, 2024
commit 444baad2190806f51a440d44544cec78d3837e54
5 changes: 3 additions & 2 deletions site/e2e/helpers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -699,15 +699,16 @@ export const createServer = async (
async function waitForPort(
port: number,
host = "0.0.0.0",
timeout = 5000,
timeout = 30000,
): Promise<void> {
const start = Date.now();
while (Date.now() - start < timeout) {
const available = await isPortAvailable(port, host);
if (available) {
return;
}
await new Promise((resolve) => setTimeout(resolve, 100)); // Wait 1 second before retrying
console.warn(`${host}:${port} is in use, checking again in 1s`)
await new Promise((resolve) => setTimeout(resolve, 1000)); // Wait 1 second before retrying
}
throw new Error(
`Timeout: port ${port} is still in use after ${timeout / 1000} seconds.`,
Expand Down
Loading