Skip to content

chore: make scim auth header case insensitive for 'bearer' #15538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 15, 2024
Merged

chore: make scim auth header case insensitive for 'bearer' #15538

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cf7ca43
chore: scim auth header case insensitive for 'bearer'
Emyrk Nov 15, 2024
4f224e2
linting
Emyrk Nov 15, 2024
d12ab22
linting
Emyrk Nov 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
linting
  • Loading branch information
@Emyrk
Emyrk committed Nov 15, 2024
commit d12ab225ec4a45d545cc1139b1de70a16038e9bd
3 changes: 2 additions & 1 deletion enterprise/coderd/scim_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ import (
"github.com/imulab/go-scim/pkg/v2/spec"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
"golang.org/x/xerrors"

"github.com/coder/coder/v2/coderd/audit"
"github.com/coder/coder/v2/coderd/coderdtest"
Expand Down Expand Up @@ -603,7 +604,7 @@ func TestScimError(t *testing.T) {

// Our error wrapper works
rw = httptest.NewRecorder()
_ = handlerutil.WriteError(rw, scim.NewHTTPError(http.StatusNotFound, spec.ErrNotFound.Type, fmt.Errorf("not found")))
_ = handlerutil.WriteError(rw, scim.NewHTTPError(http.StatusNotFound, spec.ErrNotFound.Type, xerrors.New("not found")))
resp = rw.Result()
defer resp.Body.Close()
require.Equal(t, http.StatusNotFound, resp.StatusCode)
Expand Down
Loading