Skip to content

chore(testutil): extract testutil.CreateZip and testutil.CreateTar helpers #15540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Nov 18, 2024
Merged

chore(testutil): extract testutil.CreateZip and testutil.CreateTar helpers #15540

merged 6 commits into from
Nov 18, 2024

Conversation

johnstcn
Copy link
Member

Extracts some test helpers from provisioner/terraform to be re-used elsewhere.

@johnstcn johnstcn self-assigned this Nov 15, 2024
@johnstcn johnstcn changed the title feat(testutil): extract testutil.Create(Zip|Tar) helpers chore(testutil): extract testutil.Create(Zip|Tar) helpers Nov 15, 2024
@johnstcn johnstcn mentioned this pull request Nov 16, 2024
Merged
dannykopping
dannykopping approved these changes Nov 18, 2024
View reviewed changes
Copy link
Contributor

@dannykopping dannykopping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johnstcn johnstcn changed the title chore(testutil): extract testutil.Create(Zip|Tar) helpers chore(testutil): extract testutil.CreateZip and testutil.CreateTar helpers Nov 18, 2024
@johnstcn johnstcn merged commit 4719d24 into main Nov 18, 2024
29 checks passed
@johnstcn johnstcn deleted the cj/testutil-createtar branch November 18, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dannykopping dannykopping dannykopping approved these changes

Assignees

@johnstcn johnstcn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johnstcn @dannykopping