Skip to content

fix: add error that provisionerkeys require the externalprovisioners feature #15541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 15, 2024
Merged

fix: add error that provisionerkeys require the externalprovisioners feature #15541

merged 5 commits into from
Nov 15, 2024

Conversation

aslilac
Copy link
Member

@aslilac aslilac commented Nov 15, 2024 •
edited
Loading

it currently requires the multiple organizations feature, which doesn't make for a good error message. it's a bit misleading and confusing, and would be better gated by the external provisioners feature.

I'm not actually adding an error, I'm changing an existing one, but our title bot refuses to let me name the pr accurately 🙃

@aslilac aslilac requested review from johnstcn and f0ssel November 15, 2024 18:16
@aslilac aslilac changed the title fix: warn that acquiring a provisionerkey requires the external provisioners feature fix: warn that provisionerkeys require the external provisioners feature rather than multiple organizations Nov 15, 2024
@aslilac aslilac changed the title fix: warn that provisionerkeys require the external provisioners feature rather than multiple organizations fix: require external provisioners feature for provisionerkeys Nov 15, 2024
@aslilac aslilac changed the title fix: require external provisioners feature for provisionerkeys fix: add warning when acquiring a provisionerkey without the external provisioners feature Nov 15, 2024
@aslilac aslilac changed the title fix: add warning when acquiring a provisionerkey without the external provisioners feature fix: add error that provisionerkeys require the externalprovisioners feature Nov 15, 2024
@aslilac aslilac merged commit 968c52b into main Nov 15, 2024
25 checks passed
@aslilac aslilac deleted the lilac/provisionerkeys-error branch November 15, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnstcn johnstcn johnstcn approved these changes

@f0ssel f0ssel Awaiting requested review from f0ssel

Assignees

@aslilac aslilac

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aslilac @johnstcn