fix(site): show error on template upload failure #15558
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanndickson
commented
Nov 18, 2024
| onUpload: async (file: File) => { | ||
| try { | ||
| await uploadFileMutation.mutateAsync(file); | ||
| } catch (error) { |
There was a problem hiding this comment.
I'm not familiar with this query library, but what I found is that even though you can set onError, an exception returned from mutateAsync isn't caught unless you explicitly catch it. So, If I displayed the error as part of onError in useMutation, I'd still need to wrap mutateAsync in a try block, with an empty catch, which seems pointless.
There was a problem hiding this comment.
You did it correctly. We usually use mutateAsync to keep the error handling close to where the mutation is called.
3650ef1 to
a7781d0
Compare
BrunoQuaresma
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #15441.