Skip to content

fix: use ExternalImage for external auth providers #15572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 22, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
ok this looks good
  • Loading branch information
aslilac committed Nov 22, 2024
commit f8f1fb85c2532002e852c5a1847db67b3aad47cc
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,8 @@ import type {
ListUserExternalAuthResponse,
} from "api/typesGenerated";
import { ErrorAlert } from "components/Alert/ErrorAlert";
import { Avatar } from "components/Avatar/Avatar";
import { Avatar, ExternalAvatar } from "components/Avatar/Avatar";
import { AvatarData } from "components/AvatarData/AvatarData";
import { ExternalImage } from "components/ExternalImage/ExternalImage";
import { Loader } from "components/Loader/Loader";
import {
MoreMenu,
Expand Down Expand Up @@ -153,7 +152,7 @@ const ExternalAuthRow: FC<ExternalAuthRowProps> = ({
: (link?.authenticated ?? false);

let avatar = app.display_icon ? (
<ExternalImage src={app.display_icon} />
<ExternalAvatar src={app.display_icon} variant="square" fitImage />
) : (
<Avatar>{name}</Avatar>
);
Expand Down
Loading