feat: add new scaletest infrastructure #15573
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnstcn
reviewed
Dec 10, 2024
Comment on lines
110
to
114
| - name: CODER_PROVISIONER_DAEMON_PSK | ||
| valueFrom: | ||
| secretKeyRef: | ||
| key: psk | ||
| name: "${kubernetes_secret.provisionerd_psk_europe.metadata.0.name}" |
There was a problem hiding this comment.
We should probably test with provisioner keys instead. This can be done as a follow-up, but I don't think it's a large change here as we already create workspace proxy tokens above using the CLI. It would also ensure that the provisioner daemon deployments are started after the Coder deployments are healthy.
There was a problem hiding this comment.
Will do in a follow up 👍
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes coder/internal#148
This has been validated to have working proxies with the
smallscenario.This excludes the infrastructure for
cert-managerandotel-collectorand those will be included in followup PRs.