feat(tailnet): add alias with username and short alias to DNS #15585
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spikecurtis
commented
Nov 19, 2024
| @@ -1253,15 +1258,13 @@ func (f fakeCoordinatorClient) Close() error { | |||
| errs := make(chan error) | |||
| select { | |||
| case <-f.ctx.Done(): | |||
| f.t.Error("timed out waiting to send close call") | |||
| return f.ctx.Err() | |||
| return timeoutOnFakeErr | |||
There was a problem hiding this comment.
note: changes like this are because calling t.Error() after the test case finishes (and context expires in t.Cleanup) will panic and create a bunch of extra tests to fail. So, we don't fail the test in these handlers, and instead pass a distinctive error.
There was a problem hiding this comment.
Nice! I assume it's a similar fix for coder/internal#217 too?
There was a problem hiding this comment.
Yeah, plus there was a real product bug in that one.
ethanndickson
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds DNS aliases of the form
<agent>.<workspace>.<username>.coder.and<workspace>.coder.