Skip to content

feat(site): warn on provisioner health during builds #15589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Nov 28, 2024
Merged

feat(site): warn on provisioner health during builds #15589

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
7df3b27
add alert to the create workspace page
SasSwart Nov 19, 2024
1e1262f
improve error case documentation
SasSwart Nov 19, 2024
0f78afc
add provisioner health hook
SasSwart Nov 20, 2024
f0f7216
show provisioner health warnings for templates
SasSwart Nov 21, 2024
a3eeb9c
consistent formatting for alerts across pages
SasSwart Nov 21, 2024
3cf53ef
Finalise Provisioner Warnings for Templates and template versions
SasSwart Nov 22, 2024
e281d6b
linter fixes
SasSwart Nov 22, 2024
2baa81e
Merge remote-tracking branch 'origin/main' into jjs/15048-fe
SasSwart Nov 26, 2024
0cab768
use matched_provisioners instead of a second api call
SasSwart Nov 27, 2024
b228257
provide a key to provisioner tags to keep react happy
SasSwart Nov 27, 2024
8b91dc0
fix linting issues
SasSwart Nov 27, 2024
bec2913
make fmt
SasSwart Nov 27, 2024
4796a32
Copy updates
SasSwart Nov 28, 2024
b6f99a6
make fmt
SasSwart Nov 28, 2024
aec9cba
add loader back in to build logs drawer
SasSwart Nov 28, 2024
75e7394
simplify logic
SasSwart Nov 28, 2024
0aed543
fix logic
SasSwart Nov 28, 2024
0bd9478
make fmt
SasSwart Nov 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
improve error case documentation
  • Loading branch information
@SasSwart
SasSwart committed Nov 19, 2024
commit 1e1262fb837d9cefdcdeaed4ca1d9c3d2a3045b5
7 changes: 3 additions & 4 deletions site/src/pages/CreateWorkspacePage/CreateWorkspacePageView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,12 +307,11 @@ export const CreateWorkspacePageView: FC<CreateWorkspacePageViewProps> = ({

<FormSection title="" description="">
<FormFields>
{/* TODO (SasSwart):
Is this a scenario that can occur for free-tier users? They have a default organisation and no external provisioners as far as I know.
Nothing stops them from using a template with tags defined. Will those tags interfere with job selection on internal provisioners?
*/}
{/* TODO (SasSwart):
There are multiple error scenarios here. Do they each need specific copy, or is a general message fine?
* If a free tier user with no organisations or external provisioners uses a template which requires tags:
* can they provide tags to the internal provisioners to accept the job?
* If not, the alert copy below will be confusing, because they don't use the organisations feature and we mention it.
* Could there be no provisioners whatsoever, or do we always expect at least the internal provisioners to run?
* There may be provisioners, but none with the requisite tags.
* There may be provisioners with the requisite tags, but they may not have been seen by coderd for more an unacceptable duration
Expand Down
Loading