feat: integrate new agentexec pkg #15609
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ece04fc to
5570b0b
Compare
- Removes the legacy process priority implementation and replaces current calls to os/exec and pty.Command with agentexec variants. - Adds linting ruleguards to discourage future imports of these packages.
5570b0b to
b68a46a
Compare
deansheather
approved these changes
Nov 27, 2024
deansheather
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR integrates the
agentexecpkg into the agent and removes the legacy system of iterating over the process tree. It adds some linting rules to hopefully catch improper uses ofexec.Commandin the package.