Skip to content

fix: deduplicate agent script timings #15631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 22, 2024
Merged

fix: deduplicate agent script timings #15631

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dc219e6
fix: deduplicate agent script timings
BrunoQuaresma Nov 22, 2024
3b39fba
Fix fmt
BrunoQuaresma Nov 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix fmt
  • Loading branch information
@BrunoQuaresma
BrunoQuaresma committed Nov 22, 2024
commit 3b39fba6ebbf46d2928e2570c9a5768d2258f2b7
2 changes: 1 addition & 1 deletion site/src/modules/workspaces/WorkspaceTiming/WorkspaceTimings.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,4 +117,4 @@ export const DuplicatedScriptTiming: Story = {
},
],
},
}
};
6 changes: 3 additions & 3 deletions site/src/modules/workspaces/WorkspaceTiming/WorkspaceTimings.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@ import type {
AgentScriptTiming,
ProvisionerTiming,
} from "api/typesGenerated";
import sortBy from "lodash/sortBy";
import uniqBy from "lodash/uniqBy";
import { type FC, useState } from "react";
import { type TimeRange, calcDuration, mergeTimeRanges } from "./Chart/utils";
import { ResourcesChart, isCoderResource } from "./ResourcesChart";
Expand All @@ -19,8 +21,6 @@ import {
agentStages,
provisioningStages,
} from "./StagesChart";
import sortBy from "lodash/sortBy";
import uniqBy from "lodash/uniqBy";

type TimingView =
| { name: "default" }
Expand Down Expand Up @@ -50,7 +50,7 @@ export const WorkspaceTimings: FC<WorkspaceTimingsProps> = ({
const uniqScriptTimings = uniqBy(
sortBy(agentScriptTimings, (t) => new Date(t.started_at).getTime() * -1),
(t) => t.display_name,
)
);
const timings = [
...provisionerTimings,
...uniqScriptTimings,
Expand Down
Loading