Skip to content

feat: getWorkspaces filter site api #1564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 19, 2022
Merged

feat: getWorkspaces filter site api #1564

merged 6 commits into from
May 19, 2022

Conversation

greyscaled
Copy link
Contributor

@greyscaled greyscaled commented May 18, 2022 •
edited
Loading

  • changed owner_id query param to owner
  • added frontend (particularly an exported function to create the url for a workspaces query)

@greyscaled greyscaled self-assigned this May 18, 2022
@greyscaled greyscaled requested a review from a team as a code owner May 18, 2022 18:25
@greyscaled greyscaled requested a review from Emyrk May 18, 2022 18:30
@greyscaled greyscaled marked this pull request as draft May 18, 2022 20:48
@greyscaled greyscaled marked this pull request as ready for review May 18, 2022 20:53
Emyrk
Emyrk approved these changes May 19, 2022
View reviewed changes
Copy link
Member

@Emyrk Emyrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG! Thanks for doing this. Now it's easy to add more filters 👍

@greyscaled greyscaled merged commit 67333b6 into main May 19, 2022
@greyscaled greyscaled deleted the vapurrmaid/gh-1552/getWorkspaces-filter branch May 19, 2022 16:08
@greyscaled
Copy link
Contributor Author

This resolved #1552, forgot to connect them

kylecarbs pushed a commit that referenced this pull request Jun 10, 2022
@greyscaled @kylecarbs
feat: getWorkspaces filter site api (#1564)
d457f93
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Emyrk Emyrk Emyrk approved these changes

Assignees

@greyscaled greyscaled

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@greyscaled @Emyrk