Skip to content

feat: bypass built-in CORS handling for workspace apps #15669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 12 commits into from
Closed

feat: bypass built-in CORS handling for workspace apps #15669

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
0dc7ca3
Working implementation
dannykopping Nov 21, 2024
3c0e33a
Rename CorsBehavior to CORSBehavior
dannykopping Nov 26, 2024
a4d3c8d
Hard & simplify CORORS handling logic
dannykopping Nov 27, 2024
873c3e4
Minor fixes
dannykopping Nov 27, 2024
65f984f
Appeasing the linter
dannykopping Nov 27, 2024
1f0b34c
Move type def to codersdk
dannykopping Nov 27, 2024
5be5477
Appease the linter, again
dannykopping Nov 27, 2024
ddbbaa9
Fix migration num
dannykopping Nov 28, 2024
63c1852
Removing unnecessary header check
dannykopping Nov 28, 2024
976cd78
Improve tests
dannykopping Nov 28, 2024
9f9068f
Merge branch 'main' of https://github.com/coder/coder into dk/cors
dannykopping Nov 29, 2024
3dc00e1
Comprehensive CORS test suite for both request & response
dannykopping Nov 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Appease the linter, again 
Signed-off-by: Danny Kopping <danny@coder.com>
  • Loading branch information
@dannykopping
dannykopping committed Nov 28, 2024
commit 5be547762bb9f8ad9be9d9b593b5ca6ed60f3ec8
8 changes: 4 additions & 4 deletions coderd/workspaceapps/token.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,10 @@ type SignedToken struct {
// Request details.
Request `json:"request"`

UserID uuid.UUID `json:"user_id"`
WorkspaceID uuid.UUID `json:"workspace_id"`
AgentID uuid.UUID `json:"agent_id"`
AppURL string `json:"app_url"`
UserID uuid.UUID `json:"user_id"`
WorkspaceID uuid.UUID `json:"workspace_id"`
AgentID uuid.UUID `json:"agent_id"`
AppURL string `json:"app_url"`
CORSBehavior codersdk.AppCORSBehavior `json:"cors_behavior"`
}

Expand Down
4 changes: 4 additions & 0 deletions site/src/api/typesGenerated.ts
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.