-
Notifications
You must be signed in to change notification settings - Fork 875
chore: track usage of built-in example templates #15671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This just adds the ID column, it does not add uuid
's to our built in templates yet right?
Are we going to add uuid
s to our builtins? Or should it be a string, eg: github.com/coder/templates/official/aws-linux
And do we need version control?
github.com/coder/templates/official/aws-linux@ad4efa53708e60a7094ef9687e7dfda0441aaec7
?
That's correct.
Hmm, I haven't heard anything about that before. Were there any plans?
In telemetry, we can infer the built-in template version from the deployment version. From my perspective we don't need additional version control. |
This PR adds a column to track the built in template source by uuid correct? Do built ins have a consistent uuid across all deployments? |
Built-in templates have consistent, human-readable ids. These correspond to folder names in https://github.com/coder/coder/tree/main/examples/templates. The examples are embedded in the binary here: Lines 22 to 42 in d66e041
So this PR tracks them by these human-readable ids. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Got it, that tracks!
Addresses coder/nexus#99. Changes: - Save the id of the built-in example template used to create a template version in the database - Include the example id in telemetry (cherry picked from commit b830c05)
Addresses https://github.com/coder/nexus/issues/99.
Changes: