Skip to content

fix(cli): handle version mismatch re MatchedProvisioners response #15682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Nov 29, 2024
Merged

fix(cli): handle version mismatch re MatchedProvisioners response #15682

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
a2529f7
fix(cli): handle version mismatch re MatchedProvisioners response
johnstcn Nov 28, 2024
a266455
add function
johnstcn Nov 28, 2024
f94059f
address PR comments
johnstcn Nov 29, 2024
6c4eb32
add provisioner key
johnstcn Nov 29, 2024
738f67c
partially revert change to message copy
johnstcn Nov 29, 2024
4118a94
adjust condition for checking provisioner jobs
johnstcn Nov 29, 2024
ba9c22d
hopefully address test flake
johnstcn Nov 29, 2024
bbb2861
use ptytest instead of a strings.Builder to assert cli output
johnstcn Nov 29, 2024
575e772
avoid passing in non-nil codersdk.MatchedProvisioners where not neces…
johnstcn Nov 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
hopefully address test flake
  • Loading branch information
@johnstcn
johnstcn committed Nov 29, 2024
commit ba9c22d310f9ee60440d594055a832280a0d0d06
14 changes: 7 additions & 7 deletions cli/templatepush_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -414,24 +414,22 @@ func TestTemplatePush(t *testing.T) {

t.Run("WorkspaceTagsTerraform", func(t *testing.T) {
t.Parallel()
now := dbtime.Now()
oneHourAgo := now.Add(-time.Hour)

tests := []struct {
name string
setupDaemon func(ctx context.Context, store database.Store, owner codersdk.CreateFirstUserResponse, tags database.StringMap) error
setupDaemon func(ctx context.Context, store database.Store, owner codersdk.CreateFirstUserResponse, tags database.StringMap, now time.Time) error
expectOutput string
}{
{
name: "no provisioners available",
setupDaemon: func(_ context.Context, _ database.Store, _ codersdk.CreateFirstUserResponse, _ database.StringMap) error {
setupDaemon: func(_ context.Context, _ database.Store, _ codersdk.CreateFirstUserResponse, _ database.StringMap, _ time.Time) error {
return nil
},
expectOutput: "there are no provisioners that accept the required tags",
},
{
name: "provisioner stale",
setupDaemon: func(ctx context.Context, store database.Store, owner codersdk.CreateFirstUserResponse, tags database.StringMap) error {
setupDaemon: func(ctx context.Context, store database.Store, owner codersdk.CreateFirstUserResponse, tags database.StringMap, now time.Time) error {
pk, err := store.InsertProvisionerKey(ctx, database.InsertProvisionerKeyParams{
ID: uuid.New(),
CreatedAt: now,
Expand All @@ -443,6 +441,7 @@ func TestTemplatePush(t *testing.T) {
if err != nil {
return err
}
oneHourAgo := now.Add(-time.Hour)
_, err = store.UpsertProvisionerDaemon(ctx, database.UpsertProvisionerDaemonParams{
Provisioners: []database.ProvisionerType{database.ProvisionerTypeTerraform},
LastSeenAt: sql.NullTime{Time: oneHourAgo, Valid: true},
Expand All @@ -458,7 +457,7 @@ func TestTemplatePush(t *testing.T) {
},
{
name: "active provisioner",
setupDaemon: func(ctx context.Context, store database.Store, owner codersdk.CreateFirstUserResponse, tags database.StringMap) error {
setupDaemon: func(ctx context.Context, store database.Store, owner codersdk.CreateFirstUserResponse, tags database.StringMap, now time.Time) error {
pk, err := store.InsertProvisionerKey(ctx, database.InsertProvisionerKeyParams{
ID: uuid.New(),
CreatedAt: now,
Expand Down Expand Up @@ -544,7 +543,8 @@ func TestTemplatePush(t *testing.T) {
clitest.SetupConfig(t, templateAdmin, root)

ctx := testutil.Context(t, testutil.WaitShort)
require.NoError(t, tt.setupDaemon(ctx, store, owner, wantTags))
now := dbtime.Now()
require.NoError(t, tt.setupDaemon(ctx, store, owner, wantTags, now))

cancelCtx, cancel := context.WithCancel(ctx)
t.Cleanup(cancel)
Expand Down
Loading