Skip to content

feat(site): add a provisioner warning to workspace builds #15686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 32 commits into from
Dec 11, 2024
Merged

feat(site): add a provisioner warning to workspace builds #15686

merged 32 commits into from
Dec 11, 2024

Conversation

SasSwart
Copy link
Contributor

@SasSwart SasSwart commented Nov 29, 2024 •
edited
Loading

This PR adds warnings about provisioner health to workspace build pages.
It closes #15048

image
image

@SasSwart SasSwart requested a review from johnstcn November 29, 2024 15:38
@johnstcn johnstcn mentioned this pull request Dec 2, 2024
Closed
@SasSwart SasSwart changed the title add alert for workspace provisioning feat(site): add a provisioner warning to workspace builds Dec 5, 2024
@SasSwart SasSwart requested review from BrunoQuaresma and mtojek and removed request for johnstcn December 5, 2024 09:10
@SasSwart SasSwart marked this pull request as ready for review December 5, 2024 09:11
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2024 •
edited
Loading

✔️ PR 15686 Updated successfully.
🚀 Access the credentials here.

cc: @SasSwart

mtojek
mtojek approved these changes Dec 5, 2024
View reviewed changes
Copy link
Member

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left 2 tiny nitpicks.

LGTM 👍

mtojek
mtojek approved these changes Dec 5, 2024
View reviewed changes
Copy link
Member

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it! Thanks for all changes.

@SasSwart
Copy link
Contributor Author

SasSwart commented Dec 5, 2024

Thanks @mtojek. The frontend works, but in PR env testing I noticed the backend doesn't populate the fields where it needs to. One more commit just to fix that and then we'll ship. Apologies for the premature review.

@SasSwart SasSwart requested a review from johnstcn December 9, 2024 09:18
@SasSwart SasSwart requested a review from johnstcn December 11, 2024 11:02
johnstcn
johnstcn approved these changes Dec 11, 2024
View reviewed changes
Copy link
Member

@johnstcn johnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@SasSwart SasSwart merged commit b39becb into main Dec 11, 2024
33 checks passed
@SasSwart SasSwart deleted the jjs/workspace-provisioner-alert branch December 11, 2024 11:38
@github-actions github-actions bot locked and limited conversation to collaborators Dec 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@johnstcn johnstcn johnstcn approved these changes

@mtojek mtojek mtojek approved these changes

@BrunoQuaresma BrunoQuaresma Awaiting requested review from BrunoQuaresma

Assignees

@SasSwart SasSwart

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve UX when there is no corresponding provisioner for a workspace/template
3 participants
@SasSwart @johnstcn @mtojek