Skip to content

feat(coderd): add matched provisioner daemons information to more places #15688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Dec 2, 2024
Merged

feat(coderd): add matched provisioner daemons information to more places #15688

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
ba944ab
feat(coderd/wsbuilder): return provisioners available at time of insert
johnstcn Nov 29, 2024
4e51f20
feat(coderd): add matched provisioner daemons information to addition…
johnstcn Nov 29, 2024
47036e8
fix linter complaint re nil ptr deref
johnstcn Dec 1, 2024
16be03b
add test coverage for matched provisioners with workspace build creation
johnstcn Dec 1, 2024
4304a06
skip for non-postgres
johnstcn Dec 1, 2024
9ef68dd
add tests for workspace creation
johnstcn Dec 1, 2024
38788d5
revert fe changes in this pr
johnstcn Dec 1, 2024
1c95ffe
coderd/wsbuilder: use dbauthz.AsSystemReadProvisionerDaemons instead …
johnstcn Dec 1, 2024
98521be
refactor: extract WarnMatchedProvisioners to cliutil
johnstcn Dec 1, 2024
e1423f5
fixup! refactor: extract WarnMatchedProvisioners to cliutil
johnstcn Dec 1, 2024
517a505
feat(cli): add provisioner warning to create/start/stop commands
johnstcn Dec 1, 2024
c4295ef
Apply suggestions from code review
johnstcn Dec 2, 2024
c5fb83b
feat(coderd): add endpoint for matched provisioners of template versi…
johnstcn Dec 2, 2024
3bd62fd
feat(cli): delete: warn on no matched provisioners
johnstcn Dec 2, 2024
2f625bc
address linter complaint
johnstcn Dec 2, 2024
848338e
add test for cli/delete
johnstcn Dec 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix linter complaint re nil ptr deref
  • Loading branch information
@johnstcn
johnstcn committed Dec 1, 2024
commit 47036e8a543550cde3fd74622a384fe1770f95b5
10 changes: 6 additions & 4 deletions coderd/workspacebuilds.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -387,10 +387,12 @@ func (api *API) postWorkspaceBuilds(rw http.ResponseWriter, r *http.Request) {
})
return
}
err = provisionerjobs.PostJob(api.Pubsub, *provisionerJob)
if err != nil {
// Client probably doesn't care about this error, so just log it.
api.Logger.Error(ctx, "failed to post provisioner job to pubsub", slog.Error(err))

if provisionerJob != nil {
if err := provisionerjobs.PostJob(api.Pubsub, *provisionerJob); err != nil {
// Client probably doesn't care about this error, so just log it.
api.Logger.Error(ctx, "failed to post provisioner job to pubsub", slog.Error(err))
}
Comment on lines -387 to +395
Copy link
Member Author

@johnstcn johnstcn Dec 1, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self-review: linter complained about a possible nil ptr reference in pre-existing code.

}

var matchedProvisioners codersdk.MatchedProvisioners
Expand Down