Skip to content

fix: add agent exec abstraction #15717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 4, 2024
Merged

fix: add agent exec abstraction #15717

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4a4ea64
fix: pass through agent exec abstration
sreya Dec 2, 2024
a07fe29
update lint messaging
sreya Dec 2, 2024
d8e3cda
move const
sreya Dec 2, 2024
3722d3f
grammar
sreya Dec 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update lint messaging
  • Loading branch information
@sreya
sreya committed Dec 2, 2024
commit a07fe293083270c7ee72d4794cd5b593f353e828
4 changes: 2 additions & 2 deletions scripts/rules.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -503,7 +503,7 @@ func noExecInAgent(m dsl.Matcher) {
!m.File().PkgPath.Matches("/agentexec") &&
!m.File().Name.Matches(`_test\.go$`),
).
Report("The agent and its subpackages should not use exec.Command or exec.CommandContext directly. Consider using agentexec.CommandContext instead.")
Report("The agent and its subpackages should not use exec.Command or exec.CommandContext directly. Consider using agentexec.Execer instead.")
}

// noPTYInAgent ensures that packages under agent/ don't use pty.Command or
Expand All @@ -521,5 +521,5 @@ func noPTYInAgent(m dsl.Matcher) {
!m.File().PkgPath.Matches(`/agentexec`) &&
!m.File().Name.Matches(`_test\.go$`),
).
Report("The agent and its subpackages should not use pty.Command or pty.CommandContext directly. Consider using agentexec.PTYCommandContext instead.")
Report("The agent and its subpackages should not use pty.Command or pty.CommandContext directly. Consider using a agentexec.Execer instead.")
}
Loading