Skip to content

fix: display build timings when all timings are loaded #15728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 3, 2024
Merged

fix: display build timings when all timings are loaded #15728

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6067e10
Improve comments
BrunoQuaresma Dec 2, 2024
2181bec
Refetch timings until script timings are present
BrunoQuaresma Dec 2, 2024
b16fad1
Stay on loading state when agent script timings are empty
BrunoQuaresma Dec 3, 2024
53f267b
Fix fmt
BrunoQuaresma Dec 3, 2024
0c7abee
Apply review suggestions
BrunoQuaresma Dec 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix fmt
  • Loading branch information
@BrunoQuaresma
BrunoQuaresma committed Dec 3, 2024
commit 53f267b3f82648c00d7049cf4011aec1903e7406
10 changes: 2 additions & 8 deletions site/src/api/queries/workspaceBuilds.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,15 +58,9 @@ export const infiniteWorkspaceBuilds = (
};

// We use readyAgentsCount to invalidate the query when an agent connects
export const workspaceBuildTimings = (
workspaceBuildId: string,
) => {
export const workspaceBuildTimings = (workspaceBuildId: string) => {
return {
queryKey: [
"workspaceBuilds",
workspaceBuildId,
"timings",
],
queryKey: ["workspaceBuilds", workspaceBuildId, "timings"],
queryFn: () => API.workspaceBuildTimings(workspaceBuildId),
};
};
Loading