Skip to content

feat: make username in Initialize.ps1 dynamic #15751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 6, 2024
Merged

Conversation

angrycub
Copy link
Contributor

@angrycub angrycub commented Dec 4, 2024

This PR switches the UserId from a constant to a generated values based on the script environment. This enables users to rename their machine and default user name without having to edit this element as well.

@angrycub angrycub self-assigned this Dec 4, 2024
@angrycub angrycub requested review from matifali and bpmct December 5, 2024 19:12
@angrycub angrycub marked this pull request as ready for review December 5, 2024 19:13
Copy link
Member

@matifali matifali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍🏼

@angrycub angrycub merged commit 9fe71d9 into main Dec 6, 2024
34 checks passed
@angrycub angrycub deleted the cv-fix-azure-windows-1 branch December 6, 2024 13:16
aslilac pushed a commit that referenced this pull request Dec 11, 2024
This PR switches the `UserId` from a constant to a generated values
based on the script environment. This enables users to rename their
machine and default user name without having to edit this element as
well.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants