Skip to content

fix: update workspace TTL on template TTL change #15761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Dec 6, 2024
Merged

fix: update workspace TTL on template TTL change #15761

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f99d45d
fix: update workspace TTL on template TTL change
DanielleMaywood Dec 4, 2024
3b88720
tests: refactor
DanielleMaywood Dec 5, 2024
021a806
fix: parameters
DanielleMaywood Dec 5, 2024
dca1bc7
fix: set a workspace's ttl to template's ttl if allow user autostop g…
DanielleMaywood Dec 5, 2024
d1cb4d0
chore: typos
DanielleMaywood Dec 5, 2024
66e80cf
chore: changes from feedback
DanielleMaywood Dec 6, 2024
6813615
Merge branch 'main' into dm-workspace-template-ttl
DanielleMaywood Dec 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: parameters
  • Loading branch information
@DanielleMaywood
DanielleMaywood committed Dec 5, 2024
commit 021a8066bc18b3c6528e1ce871a60d6499ae0236
2 changes: 1 addition & 1 deletion enterprise/coderd/schedule/template_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -819,7 +819,7 @@ func TestTemplateTTL(t *testing.T) {
require.NoError(t, err)
userQuietHoursStorePtr := &atomic.Pointer[agplschedule.UserQuietHoursScheduleStore]{}
userQuietHoursStorePtr.Store(&userQuietHoursStore)
templateScheduleStore := schedule.NewEnterpriseTemplateScheduleStore(userQuietHoursStorePtr, notifyEnq, logger)
templateScheduleStore := schedule.NewEnterpriseTemplateScheduleStore(userQuietHoursStorePtr, notifyEnq, logger, nil)

// Set both template's default TTL
template, err = templateScheduleStore.Set(ctx, db, template, agplschedule.TemplateScheduleOptions{
Expand Down
Loading