Skip to content

chore: fix TestWorkspaceAutobuild/NextStartAtIsValid flake #15772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

DanielleMaywood
Copy link
Contributor

Fixes coder/internal#238

It appears we haven't got quartz piped through to enough of Coder for the test to work as I had expected. Using the current time should be sufficient for this test.

@DanielleMaywood DanielleMaywood changed the title fix: TestWorkspaceAutobuild/NextStartAtIsValid flake chore: fix TestWorkspaceAutobuild/NextStartAtIsValid flake Dec 6, 2024
@DanielleMaywood DanielleMaywood marked this pull request as ready for review December 6, 2024 10:02
Copy link
Member

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing flakes!

@DanielleMaywood DanielleMaywood merged commit 67553a7 into main Dec 6, 2024
37 checks passed
@DanielleMaywood DanielleMaywood deleted the dm-fix-flake branch December 6, 2024 10:41
aslilac pushed a commit that referenced this pull request Dec 11, 2024
Fixes coder/internal#238

It appears we haven't got quartz piped through to enough of Coder for
the test to work as I had expected. Using the current time should be
sufficient for this test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

flake: TestWorkspaceAutobuild/NextStartAtIsValid
2 participants