Skip to content

docs: move premium and enterprise badges from heading to info in admonition #15774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Dec 17, 2024

Conversation

EdwardAngert
Copy link
Contributor

@EdwardAngert EdwardAngert commented Dec 6, 2024

@EdwardAngert EdwardAngert added the docs Area: coder.com/docs label Dec 6, 2024
@EdwardAngert EdwardAngert self-assigned this Dec 6, 2024
@mattvollmer
Copy link
Contributor

mattvollmer commented Dec 6, 2024

do we need to apply the same treatment to "beta" tags too? for example:

https://coder.com/docs/admin/monitoring/notifications/slack

@EdwardAngert
Copy link
Contributor Author

do we need to apply the same treatment to "beta" tags too? for example:

https://coder.com/docs/admin/monitoring/notifications/slack

@mattvollmer a beta badge doesn't seem as confusing, esp. if it's not part of the URL, but I'm open. Can we change that in another PR though? I can't tell where that's pulling from 🤔 : blob/main/docs/admin/monitoring/notifications/slack.md

@EdwardAngert EdwardAngert enabled auto-merge (squash) December 10, 2024 16:07
Copy link


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


EdwardAngert seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@EdwardAngert
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@EdwardAngert EdwardAngert merged commit 21cc6f7 into main Dec 17, 2024
33 of 34 checks passed
@EdwardAngert EdwardAngert deleted the 666-unheading-premium branch December 17, 2024 18:20
@github-actions github-actions bot locked and limited conversation to collaborators Dec 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
docs Area: coder.com/docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants