-
Notifications
You must be signed in to change notification settings - Fork 876
ci: skip running test-e2e on PRs from forks #15784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dannykopping
approved these changes
Dec 9, 2024
deansheather
reviewed
Dec 9, 2024
Co-authored-by: Dean Sheather <dean@deansheather.com>
@deansheather looks like matrix context is not available at job level.
We can either move the condition to all individual steps or skip both e2e and e2e-premium tests. |
@matifali maybe just make it skip e2e entirely for now to unblock external contributions, and we can prioritise coming up with a solution (like generating short licenses each time) |
aslilac
pushed a commit
that referenced
this pull request
Dec 11, 2024
Co-authored-by: Dean Sheather <dean@deansheather.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A workaround for #15557. We will come up with a more permanent solution