chore: add e2e tests for organization members #15807
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aslilac
commented
Dec 11, 2024
Comment on lines
+1004
to
+1030
| await page.goto("/deployment/users", { waitUntil: "domcontentloaded" }); | ||
| await expect(page).toHaveTitle("Users - Coder"); | ||
|
|
||
| await page.getByRole("button", { name: "Create user" }).click(); | ||
| await expect(page).toHaveTitle("Create User - Coder"); | ||
|
|
||
| const username = userValues.username ?? randomName(); | ||
| const name = userValues.name ?? username; | ||
| const email = userValues.email ?? `${username}@coder.com`; | ||
| const password = userValues.password || "s3cure&password!"; | ||
|
|
||
| await page.getByLabel("Username").fill(username); | ||
| if (name) { | ||
| await page.getByLabel("Full name").fill(name); | ||
| } | ||
| await page.getByLabel("Email").fill(email); | ||
| await page.getByLabel("Login Type").click(); | ||
| await page.getByRole("option", { name: "Password", exact: false }).click(); | ||
| // Using input[name=password] due to the select element utilizing 'password' | ||
| // as the label for the currently active option. | ||
| const passwordField = page.locator("input[name=password]"); | ||
| await passwordField.fill(password); | ||
| await page.getByRole("button", { name: "Create user" }).click(); | ||
| await expect(page.getByText("Successfully created user.")).toBeVisible(); | ||
|
|
||
| await expect(page).toHaveTitle("Users - Coder"); | ||
| await expect(page.locator("tr", { hasText: email })).toBeVisible(); |
There was a problem hiding this comment.
This is all taken verbatim from the existing createUserWithPassword test. It just seems like the kind of thing that's helpful to turn into a reusable function.
jaaydenh
approved these changes
Dec 11, 2024
|
Yeah, custom roles have their own ticket for adding tests. That's up next. |
|
Closes coder/internal#165 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.