feat: create e2e tests for organization custom roles page #15814
Conversation
| await deleteOrganization("testers"); | ||
| }); | ||
|
|
||
| test("create custom role with UI", async ({ page }) => { |
There was a problem hiding this comment.
why not make this a helper and call it from the other test rather than using the api?
There was a problem hiding this comment.
I have actually been going the route of having 2 different types of tests, one that starts with a change using the api and then completing the test through the UI and then another that does the same thing through the UI. I think there is the potential catching edge cases through this way of testing.
There was a problem hiding this comment.
@aslilac Looking around at many of the existing tests, I see this pattern when the same things to happen for many tests, for example creating a template, the API is used but then atleast one test would do the same thing through the UI if possible. I feel like this many be a bit more performant than going through the UI for every test. The except would be if there are many variations of path the user could take through the UI.
Adds 5 premium tests and 1 non-premium test.