Skip to content

fix: disable init() function in github/charmbracelet/bubbletea dependency #15817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 16, 2024
Merged

fix: disable init() function in github/charmbracelet/bubbletea dependency #15817

merged 3 commits into from
Dec 16, 2024

Conversation

sreya
Copy link
Collaborator

@sreya sreya commented Dec 10, 2024 •
edited
Loading

Fixes an issue where an init function causes writes to the terminal when using agent-exec which results in some ansi characters being printed to the web terminal like so

^[]11;rgb:0909/0909/0b0b^[\^[[1;1Rl
coder@dev coder (main) 
execute: 0909/0909/0b0b\[1;1Rlls_

It also causes a significant slowdown in how long the web terminals take to launch. Pretty unfortunate...I tried getting around it but couldn't find a good answer. This is ultimately what was causing the drama.

@sreya sreya changed the title fix: disable github/charmbracelete/bubbletea init() fix: disable init() function in github/charmbracelete/bubbletea Dec 10, 2024
@sreya sreya changed the title fix: disable init() function in github/charmbracelete/bubbletea fix: disable init() function in github/charmbracelete/bubbletea dependency Dec 10, 2024
@sreya sreya changed the title fix: disable init() function in github/charmbracelete/bubbletea dependency fix: disable init() function in github/charmbracelet/bubbletea dependency Dec 10, 2024
@sreya sreya requested a review from deansheather December 11, 2024 20:03
@sreya
Copy link
Collaborator Author

sreya commented Dec 11, 2024

@deansheather once you're ok i'll create a fork under the coder org

deansheather
deansheather approved these changes Dec 12, 2024
View reviewed changes
Copy link
Member

@deansheather deansheather left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me, but can you move/refork it under the coder org before you merge?

@sreya sreya merged commit 05914cb into main Dec 16, 2024
30 checks passed
@sreya sreya deleted the jon/fixinit branch December 16, 2024 18:58
@github-actions github-actions bot locked and limited conversation to collaborators Dec 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@deansheather deansheather deansheather approved these changes

Assignees

@sreya sreya

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sreya @deansheather