Skip to content

fix: encode .dockerconfigjson value for kubernetes-devcontainer example template #15819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 16, 2024
Merged

fix: encode .dockerconfigjson value for kubernetes-devcontainer example template #15819

merged 1 commit into from
Dec 16, 2024
+1 −1

Conversation

duchuyvp
Copy link
Contributor

@duchuyvp duchuyvp commented Dec 11, 2024 •
edited
Loading

Value of .dockerconfigjson in kubernetes_secret datasource is already decoded, so I encode it again to avoid error for ENVBUILDER_DOCKER_CONFIG_BASE64

@cdr-bot cdr-bot bot added the community Pull Requests and issues created by the community. label Dec 11, 2024
@duchuyvp duchuyvp changed the title Fix ENVBUILDER_DOCKER_CONFIG_BASE64 value for kubernetes-devcontainer example template fix: encode ENVBUILDER_DOCKER_CONFIG_BASE64 value for kubernetes-devcontainer example template Dec 11, 2024
@duchuyvp duchuyvp changed the title fix: encode ENVBUILDER_DOCKER_CONFIG_BASE64 value for kubernetes-devcontainer example template fix: encode .dockerconfigjson value for kubernetes-devcontainer example template Dec 11, 2024
@matifali matifali requested a review from johnstcn December 11, 2024 04:37
@duchuyvp
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 11, 2024 •
edited
Loading

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@duchuyvp
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@duchuyvp
Copy link
Contributor Author

recheck

@johnstcn
Copy link
Member

@duchuyvp Sorry, something's up with our CLA. We're looking into it.

cdrci2 added a commit to coder/cla that referenced this pull request Dec 11, 2024
@cdrci2
@duchuyvp has signed the CLA in coder/coder#15819
b913f49
johnstcn
johnstcn approved these changes Dec 12, 2024
View reviewed changes
Copy link
Member

@johnstcn johnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this @duchuyvp!
In the process of testing this change, I also uncovered some separate issues. I'll submit some separate PRs for those.

@duchuyvp
Copy link
Contributor Author

@johnstcn that's good.

@johnstcn johnstcn merged commit 2eee201 into coder:main Dec 16, 2024
38 of 42 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@johnstcn johnstcn johnstcn approved these changes

Assignees

@duchuyvp duchuyvp

Labels
community Pull Requests and issues created by the community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@duchuyvp @johnstcn