Skip to content

chore: add e2e test for org groups #15853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 13, 2024
Merged

chore: add e2e test for org groups #15853

merged 3 commits into from
Dec 13, 2024

Conversation

aslilac
Copy link
Member

@aslilac aslilac commented Dec 12, 2024

@aslilac aslilac requested a review from jaaydenh December 12, 2024 21:49
jaaydenh
jaaydenh approved these changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@jaaydenh jaaydenh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only question is if there should also be a test for the quota on the group settings page or if you consider that out of scope for these tests?

@aslilac aslilac force-pushed the lilac/e2e-org-groups branch from 113e428 to bac9d8f Compare December 13, 2024 23:01
@aslilac aslilac merged commit c92f480 into main Dec 13, 2024
29 checks passed
@aslilac aslilac deleted the lilac/e2e-org-groups branch December 13, 2024 23:14
@github-actions github-actions bot locked and limited conversation to collaborators Dec 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jaaydenh jaaydenh jaaydenh approved these changes

Assignees

@aslilac aslilac

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tests(e2e): add a crud test for organization groups
2 participants
@aslilac @jaaydenh