fix(vpn): use unbuffered channel in speaker #15863
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes coder/internal#253.
The Tunnel closing mechanism encounters a race if the passed
io.ReadWriteCloser
is shared between the Tunnel and the Manager, specifically if the closing of the Conn by one causes a read fail on the other.The sequence of events during the flakey tests is as follows:
sendch
net.Pipe
gets closed by Tunnel'ssendLoop
endingserdes
reads the response successfully and passes it to the speaker via therecvCh
.respCh
. TherespCh
is buffered so this is non-blocking.recvLoopDone
channel is closed by therecvCh
getting closed (by failing to read from the closed conn)unaryRPC
is finally scheduled to run, where both of these conditions in a select block are ready, and so whether or not the response is returned is random.The solution is to therefore make the
respCh
unbuffered. That way, it's not possible for therecvLoopDone
channel to be closed until therespCh
is read from.