Skip to content

fix: allow users to extend their running workspace's deadline #15895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 18, 2024

Conversation

DanielleMaywood
Copy link
Contributor

Fixes #15515

This change effectively reverts the changes introduced by #13182 (for #13078).

We also rename the override-stop command name to extend to match the API endpoint's name.

@DanielleMaywood DanielleMaywood marked this pull request as ready for review December 17, 2024 15:13
Copy link
Member

@johnstcn johnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we keep override-stop as an alias for existing use?

@DanielleMaywood DanielleMaywood changed the title fix!: allow users to extend their running workspace's deadline fix: allow users to extend their running workspace's deadline Dec 18, 2024
@DanielleMaywood
Copy link
Contributor Author

Can we keep override-stop as an alias for existing use?

Yep, have added it as an alias (and added a test for it)

@DanielleMaywood DanielleMaywood merged commit 91875c2 into main Dec 18, 2024
37 checks passed
@DanielleMaywood DanielleMaywood deleted the dm-extend-autostop-permissions branch December 18, 2024 10:58
@github-actions github-actions bot locked and limited conversation to collaborators Dec 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How can I bump autostop to leave room for long-running scripts?
2 participants