Skip to content

fix: adjust validation errors for template schedule form #15915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 18, 2024
Merged

Conversation

mtojek
Copy link
Member

@mtojek mtojek commented Dec 18, 2024

Fixes: #15910

This PR sets custom validation errors for the Template Schedule form when the given value is not integer.

@mtojek mtojek self-assigned this Dec 18, 2024
@mtojek mtojek requested a review from matifali December 18, 2024 12:35
@mtojek mtojek marked this pull request as ready for review December 18, 2024 12:36
Copy link
Member

@matifali matifali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I didn't know that we can do this that simply.

@mtojek mtojek merged commit 7c82b83 into main Dec 18, 2024
36 checks passed
@mtojek mtojek deleted the 15910-fix branch December 18, 2024 12:38
@github-actions github-actions bot locked and limited conversation to collaborators Dec 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

confusing messaging on template schedule settings page
2 participants