chore: record and raise problematic http protocols for each proxy #15917
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aslilac
reviewed
Dec 18, 2024
site/src/pages/UserSettingsPage/WorkspaceProxyPage/WorkspaceProxyRow.tsx
Outdated
Show resolved
Hide resolved
Comment on lines
37
to
41
| `Requests to the proxy are using ${latency.nextHopProtocol}, ` + | ||
| "the server might not support HTTP/2. " + | ||
| "For usability reasons, HTTP/2 or above is recommended. " + | ||
| "Pages may fail to load if the web browser's concurrent " + | ||
| "connection limit is reached.", |
There was a problem hiding this comment.
I find this description really unclear. Requests to the proxy from where? What server? Why is there a comma separating what feels like two sentences? I think this needs a bit more refinement
There was a problem hiding this comment.
How about:
`Requests to the proxy from current browser are using "${latency.nextHopProtocol}". ` +
"The proxy server might not support HTTP/2. " +
"For usability reasons, HTTP/2 or above is recommended. " +
"Pages may fail to load if the web browser's concurrent " +
"connection limit per host is reached.",
aslilac
approved these changes
Dec 19, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #15887
Adds warnings to the proxy and proxy health pages on HTTP 1.1, 1.0, 0.9 protocols.
Implementation notes
Only the performance API can return the HTTP protocol type. We already use the performance API for latency timings, and each proxy could have this issue. So it made the most sense to put the warnings here.
Imo we should raise this error to admins more seriously and obviously, but that can wait.