Skip to content

chore: use docker host in docker-compose #1592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 19, 2022
Merged

chore: use docker host in docker-compose #1592

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2891f33
chore: use docker host in docker-compose
bpmct May 19, 2022
6502656
remove hardcoded access URLs from examples itself
bpmct May 19, 2022
d5f9756
remove coder address passthrough
bpmct May 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion docker-compose.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,15 @@
version: "3.9"
services:
coder:
image: ghcr.io/coder/coder:v${CODER_VERSION:-0.5.6}-${ARCH:-amd64}
image: ghcr.io/coder/coder:v${CODER_VERSION:-0.5.10}-${ARCH:-amd64}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wish dependabot/dependabot-core#390 existed. Maybe we use Renovate or another tool?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we've even got 0.5.11 right now!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems the release was deleted: https://github.com/coder/coder/releases/

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair point then!

ports:
- "7080:7080"
environment:
CODER_PG_CONNECTION_URL: "postgresql://${POSTGRES_USER:-username}:${POSTGRES_PASSWORD:-password}@database/${POSTGRES_DB:-coder}?sslmode=disable"
CODER_ADDRESS: "0.0.0.0:7080"
# You'll need to set CODER_ACCESS_URL to an
# externally-reachable IP to use non-Docker examples!
CODER_ACCESS_URL: "${CODER_ACCESS_URL:-http://host.docker.internal:7080}"
volumes:
- /var/run/docker.sock:/var/run/docker.sock
depends_on:
Expand Down
3 changes: 0 additions & 3 deletions examples/docker-image-builds/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,9 +42,6 @@ provider "docker" {
}

provider "coder" {
# The below assumes your Coder deployment is running in docker-compose.
# If this is not the case, either comment or edit the below.
url = "http://host.docker.internal:7080"
}

data "coder_workspace" "me" {
Expand Down
3 changes: 0 additions & 3 deletions examples/docker/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,9 +49,6 @@ provider "docker" {
}

provider "coder" {
# The below assumes your Coder deployment is running in docker-compose.
# If this is not the case, either comment or edit the below.
url = "http://host.docker.internal:7080"
}

data "coder_workspace" "me" {
Expand Down