Skip to content

feat: add workspace-proxy-url flag to scaletest workspace-traffic #15920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 18, 2024
Merged

feat: add workspace-proxy-url flag to scaletest workspace-traffic #15920

merged 1 commit into from
Dec 18, 2024

Conversation

f0ssel
Copy link
Contributor

@f0ssel f0ssel commented Dec 18, 2024 •
edited
Loading

This allows the command to target a workspace proxy when appropriate.

Part of coder/internal#149

So far I've verified the correct url being used with logs:

➜  coder git:(f0ssel/workspace-traffic-proxy) ✗ go run ./cmd/coder/main.go exp scaletest workspace-traffic --job-timeout=60s --workspace-proxy-url="https://paris.fly.dev.coder.com"
Running load test...

web url: https://paris.fly.dev.coder.com

...

➜  coder git:(f0ssel/workspace-traffic-proxy) ✗ go run ./cmd/coder/main.go exp scaletest workspace-traffic --job-timeout=60s --workspace-proxy-url="https://paris.fly.dev.coder.com" --app="code-server"
Running load test...

app url: https://paris.fly.dev.coder.com/@f0ssel/scaletest-1.dev/apps/code-server

@f0ssel f0ssel requested a review from johnstcn December 18, 2024 16:51
johnstcn
johnstcn approved these changes Dec 18, 2024
View reviewed changes
Copy link
Member

@johnstcn johnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@f0ssel f0ssel merged commit 50333d3 into main Dec 18, 2024
34 checks passed
@f0ssel f0ssel deleted the f0ssel/workspace-traffic-proxy branch December 18, 2024 16:53
@github-actions github-actions bot locked and limited conversation to collaborators Dec 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@johnstcn johnstcn johnstcn approved these changes

Assignees

@f0ssel f0ssel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@f0ssel @johnstcn