feat: notify on workspace creation #15934
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnstcn
approved these changes
Dec 20, 2024
There was a problem hiding this comment.
LGTM, some suggestions below but nothing blocking:
- Regarding your
coderdtests, it's good practice to "drop privileges" by creating a separate user with the minimum permission set for the behaviour you want to test, and testing with that user. This will catch RBAC-related bugs. - As it's also possible to create workspaces on behalf of other users, we should also test the behaviour in this workflow.
There was a problem hiding this comment.
Obligatory prod to double-check migration number before merging :-)
johnstcn
approved these changes
Dec 20, 2024
Comment on lines
+118
to
+121
| func WithTemplateID(id uuid.UUID) func(*FakeNotification) bool { | ||
| return func(n *FakeNotification) bool { | ||
| return n.TemplateID == id | ||
| } |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #15845
This PR introduces notifications for when workspaces are created.
Each notification contains some metadata about the workspace that has been created. I've intentionally limited this information to just IDs and names, as we can always add more data if requested/desired.
Adding the new notification caused other unrelated tests to fail due to how they were checking for the right notification. I've updated these tests to use a new helper function
SentWithTemplateIDto hopefully reduce the likelihood of further notifications to cause a cascade of test failures.