Skip to content

feat: allow entering non-default values in multi-select #15935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 27, 2024
Merged

feat: allow entering non-default values in multi-select #15935

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ce4b3c2
feat: allow entering non-default values in multi-select
joobisb Dec 19, 2024
cc41fe7
fix: duplicates, cursor positioning
joobisb Dec 20, 2024
3a3ee03
chore: remove unwanted change
joobisb Dec 20, 2024
37e2dd4
remove case insensitive matching
joobisb Dec 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: remove unwanted change
  • Loading branch information
@joobisb
joobisb committed Dec 20, 2024
commit 3a3ee034ea7ebab9d883074a664e4031cff15ac7
8 changes: 4 additions & 4 deletions cli/cliui/select.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@ func (m selectModel) Update(msg tea.Msg) (tea.Model, tea.Cmd) {
if m.cursor > 0 {
m.cursor--
} else {
m.cursor = len(options)
m.cursor = len(options) - 1
}

case tea.KeyDown:
Expand Down Expand Up @@ -378,9 +378,9 @@ type multiSelectModel struct {
message string
canceled bool
selected bool
isCustomInputMode bool // New field to track if we're adding a custom option
customInput string // New field to store custom input
enableCustomInput bool // New field to control whether custom input is allowed
isCustomInputMode bool // track if we're adding a custom option
customInput string // store custom input
enableCustomInput bool // control whether custom input is allowed
}

func (multiSelectModel) Init() tea.Cmd {
Expand Down
Loading