chore(coderd/coderdtest): wait for provisioner daemons to be connected #15936
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spikecurtis
reviewed
Dec 19, 2024
coderd/coderdtest/coderdtest.go
Outdated
| func AwaitProvisionerDaemonsConnected(t testing.TB, api *coderd.API) { | ||
| ctx, cancel := context.WithTimeout(context.Background(), testutil.WaitShort) | ||
| defer cancel() | ||
| for { |
There was a problem hiding this comment.
Instead of this polling loop with potentially noisy logs, what if we made a slight addition to the provisionerd.Server such that it closes or sends on a buffered channel when it connects for the first time. This is how the tailnet dialer works.
Then we could select on that channel (vs ctx.Done()) rather than polling.
There was a problem hiding this comment.
I tried this out, except at the provisionerd level itself. LMK if that suits, or I can circle back and do it in the provisionerd server as you suggested.
spikecurtis
approved these changes
Dec 20, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes coder/internal#260