chore(examples/templates/digitalocean-linux): make template more friendly #15938
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@matifali I think we should let template admins set the DigitalOcean token as a template variable instead of enforcing only the |
|
@phorcys420 Can we make the variable optional and only ask if there is no |
|
@matifali we can make it optional but i don't think we can hide it based on an env variable, i will try |
|
Tested on dogfood via relaxed_hamilton6 (token revoked) |
63684e3 to
47a3808
Compare
matifali
reviewed
Dec 24, 2024
matifali
reviewed
Dec 24, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to make the DigitalOcean Linux template more user friendly for first-time users.