Skip to content

feat: add provisioner daemon and jobs endpoints and commands #15940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 21 commits into from
Closed

feat: add provisioner daemon and jobs endpoints and commands #15940

Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
650cbaf
feat: add provisioners and jobs endspoints and CLI commands
mafredri Dec 19, 2024
449df5d
wip
mafredri Dec 19, 2024
fa261b1
key
mafredri Dec 19, 2024
c5a0429
golden
mafredri Dec 19, 2024
b138faf
name
mafredri Dec 19, 2024
a0af6eb
gen
mafredri Dec 19, 2024
8975d41
test
mafredri Dec 20, 2024
96a278e
dbmem
mafredri Dec 20, 2024
e9b8725
typo
mafredri Dec 20, 2024
c5211ef
fix migrations
mafredri Dec 20, 2024
c6e1cc6
cleanup
mafredri Dec 20, 2024
9e64cdd
improve tests and dbmem
mafredri Dec 20, 2024
8fd1a6a
Update cli/provisionerjobs.go
mafredri Dec 20, 2024
b57bc8c
lint
mafredri Dec 20, 2024
32fde66
remove unused
mafredri Dec 20, 2024
38116d7
gen, remove unused
mafredri Dec 20, 2024
e7ac032
slice.ToStringEnums
mafredri Dec 20, 2024
f6c2a3f
lint & gen
mafredri Dec 22, 2024
876bd80
dbmem/golden
mafredri Dec 31, 2024
0788d56
revert
mafredri Dec 31, 2024
24d49da
undo rename
mafredri Dec 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
revert
  • Loading branch information
@mafredri
mafredri committed Jan 2, 2025
commit 0788d5602b5ad8952b89378498e731eecb52ea7c
25 changes: 12 additions & 13 deletions cli/clitest/golden.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ import (
"strings"
"testing"

"github.com/google/go-cmp/cmp"
"github.com/google/uuid"
"github.com/stretchr/testify/require"

Expand Down Expand Up @@ -96,32 +95,32 @@ ExtractCommandPathsLoop:

// TestGoldenFile will test the given bytes slice input against the
// golden file with the given file name, optionally using the given replacements.
func TestGoldenFile(t *testing.T, fileName string, got []byte, replacements map[string]string) {
t.Helper()

if len(got) == 0 {
func TestGoldenFile(t *testing.T, fileName string, actual []byte, replacements map[string]string) {
if len(actual) == 0 {
t.Fatal("no output")
}

for k, v := range replacements {
got = bytes.ReplaceAll(got, []byte(k), []byte(v))
actual = bytes.ReplaceAll(actual, []byte(k), []byte(v))
}

got = normalizeGoldenFile(t, got)
actual = normalizeGoldenFile(t, actual)
goldenPath := filepath.Join("testdata", strings.ReplaceAll(fileName, " ", "_")+".golden")
if *UpdateGoldenFiles {
t.Logf("update golden file for: %q: %s", fileName, goldenPath)
err := os.WriteFile(goldenPath, got, 0o600)
err := os.WriteFile(goldenPath, actual, 0o600)
require.NoError(t, err, "update golden file")
}

want, err := os.ReadFile(goldenPath)
expected, err := os.ReadFile(goldenPath)
require.NoError(t, err, "read golden file, run \"make update-golden-files\" and commit the changes")

want = normalizeGoldenFile(t, want)
if diff := cmp.Diff(string(want), string(got)); diff != "" {
require.Failf(t, "golden file mismatch, run \"make update-golden-files\", verify and commit the changes", "%s: diff (-want +got)\n%s", goldenPath, diff)
}
expected = normalizeGoldenFile(t, expected)
require.Equal(
t, string(expected), string(actual),
"golden file mismatch: %s, run \"make update-golden-files\", verify and commit the changes",
goldenPath,
)
}

// normalizeGoldenFile replaces any strings that are system or timing dependent
Expand Down