Skip to content

test(cli/clitest): pad replacements for table alignment #15942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 19, 2024
Merged

test(cli/clitest): pad replacements for table alignment #15942

merged 1 commit into from
Dec 19, 2024

Conversation

mafredri
Copy link
Member

@mafredri mafredri commented Dec 19, 2024 •
edited
Loading

I found golden file tables hard to look at with the misalignment, this PR attempts make it a bit better.

@mafredri mafredri requested a review from Emyrk December 19, 2024 19:10
Emyrk
Emyrk approved these changes Dec 19, 2024
View reviewed changes
Copy link
Member

@Emyrk Emyrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Fine with me

@mafredri mafredri merged commit d59fddb into main Dec 19, 2024
33 of 34 checks passed
@mafredri mafredri deleted the mafredri/test-golden-replacement-alignment branch December 19, 2024 22:06
@github-actions github-actions bot locked and limited conversation to collaborators Dec 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Emyrk Emyrk Emyrk approved these changes

Assignees

@mafredri mafredri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mafredri @Emyrk