Skip to content

fix: provide useful debug info when retrieving a version from GitHub fails #15956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 9, 2025
Merged

fix: provide useful debug info when retrieving a version from GitHub fails #15956

merged 1 commit into from
Jan 9, 2025

Conversation

dannykopping
Copy link
Contributor

@dannykopping dannykopping commented Dec 24, 2024 •
edited
Loading

Closes #15851

This fails the installation when the version cannot be retrieved, and prints useful debug info.

install.sh could use with more error-handling in general, but this at least ameliorates the linked issue.

@dannykopping dannykopping changed the title Print useful debug info when retrieving a version from GitHub fails fix: print useful debug info when retrieving a version from GitHub fails Dec 24, 2024
@dannykopping dannykopping marked this pull request as ready for review December 24, 2024 15:58
@dannykopping
Print useful debug info when retrieving a version from GitHub fails
44fc85b 
Signed-off-by: Danny Kopping <danny@coder.com>
Parkreiner
Parkreiner reviewed Dec 26, 2024
View reviewed changes
Copy link
Member

@Parkreiner Parkreiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely not a Bash expert, but if Cian can't get to this by tomorrow morning, I'll get up to speed on the syntax and trudge through things tomorrow

Parkreiner
Parkreiner approved these changes Dec 27, 2024
View reviewed changes
Copy link
Member

@Parkreiner Parkreiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Went through everything, and it looks good. Sorry I didn't get this approved earlier today

@github-actions github-actions bot added the stale This issue is like stale bread. label Jan 6, 2025
@dannykopping dannykopping changed the title fix: print useful debug info when retrieving a version from GitHub fails provide useful debug info when retrieving a version from GitHub fails Jan 9, 2025
@dannykopping dannykopping enabled auto-merge (squash) January 9, 2025 09:46
@dannykopping dannykopping changed the title provide useful debug info when retrieving a version from GitHub fails fix: provide useful debug info when retrieving a version from GitHub fails Jan 9, 2025
@dannykopping dannykopping merged commit 401f8b4 into main Jan 9, 2025
33 of 34 checks passed
@dannykopping dannykopping deleted the dk/install branch January 9, 2025 09:47
@github-actions github-actions bot locked and limited conversation to collaborators Jan 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@johnstcn johnstcn johnstcn approved these changes

@Parkreiner Parkreiner Parkreiner approved these changes

Assignees

@dannykopping dannykopping

Labels
stale This issue is like stale bread.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

install.sh script intermittently fails when trying to fetch releases from GitHub API
3 participants
@dannykopping @johnstcn @Parkreiner