Skip to content

docs: update external auth to better explain process #15970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 3, 2025
Merged

docs: update external auth to better explain process #15970

merged 4 commits into from
Jan 3, 2025

Conversation

ChristopherJTrent
Copy link
Contributor

Reference #15968

Adds more information on how to add external auth, including docker-compose and docker CLI examples and terraform code for template integration.

@cdr-bot cdr-bot bot added the community Pull Requests and issues created by the community. label Dec 28, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 28, 2024 •
edited
Loading

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@ChristopherJTrent
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

cdrci2 added a commit to coder/cla that referenced this pull request Dec 28, 2024
@cdrci2
@ChristopherJTrent has signed the CLA in coder/coder#15970
711bb8b
@ChristopherJTrent ChristopherJTrent changed the title [docs] update external auth to better explain process chore(documentation): update external auth to better explain process Dec 28, 2024
@ChristopherJTrent ChristopherJTrent changed the title chore(documentation): update external auth to better explain process chore(docs): update external auth to better explain process Dec 28, 2024
matifali
matifali approved these changes Dec 30, 2024
View reviewed changes
Copy link
Member

@matifali matifali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution. @ChristopherJTrent

I would wait for @EdwardAngert to review before merging.

matifali
matifali approved these changes Dec 30, 2024
View reviewed changes
Copy link
Member

@matifali matifali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few more suggestions which I think would help improve the page.

@ChristopherJTrent
Copy link
Contributor Author

I will wait on making a decision on the requested changes until Mr. Angert has had a chance to put in his two cents.

@matifali matifali changed the title chore(docs): update external auth to better explain process docs: update external auth to better explain process Dec 31, 2024
@EdwardAngert EdwardAngert changed the base branch from main to 15970-external-auth-update January 2, 2025 20:51
@EdwardAngert
Copy link
Contributor

thanks @ChristopherJTrent (and @matifali)

Looks like there are a number of edits we want to make to the external auth doc. I changed the base to a branch on the Coder repo so that we can accept and add to your changes. Please feel free to make/accept/reject whatever changes you want to here, and I'll tag you on the new PR to main so that you can review and jump in 🙌

ChristopherJTrent and others added 2 commits January 2, 2025 13:06
@ChristopherJTrent
Copy link
Contributor Author

Thank you @EdwardAngert, I'm all done over here. Looking forward to seeing what the team has planned for this page ^.^

@EdwardAngert EdwardAngert merged commit 2db695b into coder:15970-external-auth-update Jan 3, 2025
5 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@matifali matifali matifali approved these changes

@EdwardAngert EdwardAngert Awaiting requested review from EdwardAngert

Assignees

@ChristopherJTrent ChristopherJTrent

Labels
community Pull Requests and issues created by the community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChristopherJTrent @EdwardAngert @matifali