Skip to content

fix(enterprise/cli): add missing defer close of closer funcs #15986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 31, 2024

Conversation

mafredri
Copy link
Member

This change ensures the closers are actually called on exit.

Additional rename of shadowed type.

Extracted from #15940.

@mafredri mafredri self-assigned this Dec 31, 2024
@mafredri mafredri requested review from Emyrk and mtojek December 31, 2024 13:15
@mafredri mafredri enabled auto-merge (squash) December 31, 2024 14:29
@mafredri mafredri merged commit f517e5f into main Dec 31, 2024
31 checks passed
@mafredri mafredri deleted the mafredri/fix-enterprise-cli-closers branch December 31, 2024 14:39
@github-actions github-actions bot locked and limited conversation to collaborators Dec 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants