Skip to content

ci: make sure golden files are actually up to date #15989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 2, 2025
Merged

ci: make sure golden files are actually up to date #15989

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ad30736
ci: make sure golden files are actually up to date
mafredri Dec 31, 2024
bfba244
move detached comment
mafredri Dec 31, 2024
42616f2
sync chart_test.go between coder and provisioner
mafredri Dec 31, 2024
22fd471
fix notif gen
mafredri Dec 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
sync chart_test.go between coder and provisioner
  • Loading branch information
@mafredri
mafredri committed Dec 31, 2024
commit 42616f2be1c3851e50b39c5e4b75d4858b1937ea
7 changes: 6 additions & 1 deletion helm/provisioner/tests/chart_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,7 @@ func TestRenderChart(t *testing.T) {
helmPath := lookupHelm(t)
err := updateHelmDependencies(t, helmPath, "..")
require.NoError(t, err, "failed to build Helm dependencies")

for _, tc := range testCases {
tc := tc
t.Run(tc.name, func(t *testing.T) {
Expand Down Expand Up @@ -162,6 +163,9 @@ func TestUpdateGoldenFiles(t *testing.T) {
}

helmPath := lookupHelm(t)
err := updateHelmDependencies(t, helmPath, "..")
require.NoError(t, err, "failed to build Helm dependencies")

for _, tc := range testCases {
if tc.expectedError != "" {
t.Logf("skipping test case %q with render error", tc.name)
Expand All @@ -171,7 +175,8 @@ func TestUpdateGoldenFiles(t *testing.T) {
valuesPath := tc.valuesFilePath()
templateOutput, err := runHelmTemplate(t, helmPath, "..", valuesPath)
if err != nil {
t.Logf("Command output:\n%s", templateOutput)
t.Logf("error running `helm template -f %q`: %v", valuesPath, err)
t.Logf("output: %s", templateOutput)
}
require.NoError(t, err, "failed to run `helm template -f %q`", valuesPath)

Expand Down
Loading