Skip to content

docs: document issue with direnv and nix-shell on macOS #15990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

paulroub
Copy link
Contributor

Including the suggested -- and tested -- workaround and a link to the direnv issue.

Including the suggested -- and tested -- workaround and a link to the direnv issue.
@cdr-bot cdr-bot bot added the community Pull Requests and issues created by the community. label Dec 31, 2024
Copy link

github-actions bot commented Dec 31, 2024

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@paulroub paulroub changed the title Note current problem with direnv and nix-shell with macOS docs: Note current problem with direnv and nix-shell with macOS Dec 31, 2024
@paulroub paulroub changed the title docs: Note current problem with direnv and nix-shell with macOS docs: note current problem with direnv and nix-shell with macOS Dec 31, 2024
@paulroub paulroub changed the title docs: note current problem with direnv and nix-shell with macOS docs: document issue with direnv and nix-shell on macOS Dec 31, 2024
@paulroub
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

cdrci2 added a commit to coder/cla that referenced this pull request Dec 31, 2024
@matifali matifali requested a review from mtojek January 1, 2025 10:53
@@ -46,6 +46,13 @@ direnv: export +AR +AS +CC +CONFIG_SHELL +CXX +HOST_PATH +IN_NIX_SHELL +LD +NIX_
🎉
```

> **Note:** On macOS, a [direnv bug](https://github.com/direnv/direnv/issues/1345) can cause `nix-shell` to fail to build or run `coder`. If you see `error: creating directory` when attempting to run, build, or test, adding one line to your `.envrc` should fix the problem:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly, I would create a subsection for Troubleshooting and mention this issue. Otherwise, there is a risk we'll end up with 10 notes referring different issues.

I'll defer the final decision to @EdwardAngert 👍

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @paulroub ! I do agree with @mtojek , but there are a few more (unrelated) things I want to edit in this doc. I'll approve this as is, and follow-up in a little while

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a trick (beyond commenting "recheck", which isn't doing it) to have the contrib / cla check redone?

Copy link
Contributor

@EdwardAngert EdwardAngert Jan 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might just be busted, @paulroub

I had this issue with some of my own PRs - some I was able to fix when I confirmed my git config user and email (pasting below, just in case), and some just still fail. We're working on figuring out why and fixing it, but it's not a required check for us to merge

git config --local user.name "myusername" && \
git config --local user.email "no-reply-email+myusername@users.noreply.github.com"

edit: scratch that - looks like you've been added in coder/cla@061cd21

@mtojek mtojek requested a review from EdwardAngert January 2, 2025 09:02
@EdwardAngert
Copy link
Contributor

I'm changing the base branch so that I can test some linting and add some edits on that branch

@EdwardAngert EdwardAngert changed the base branch from main to 15990-contrib-nix-shell January 2, 2025 17:47
@EdwardAngert EdwardAngert merged commit d10d9b5 into coder:15990-contrib-nix-shell Jan 2, 2025
16 of 21 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 2, 2025
@paulroub paulroub deleted the patch-1 branch January 2, 2025 18:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
community Pull Requests and issues created by the community.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants