Skip to content

feat(coderd/database): track user status changes over time #16019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 32 commits into from
Jan 13, 2025
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
cd953a3
add user_status_changes table
SasSwart Dec 14, 2024
ec16728
add GetUserStatusCountsByDay
SasSwart Dec 14, 2024
0d97e82
rename unused variable
SasSwart Dec 14, 2024
eb6e249
Test GetUserStatusCountsByDay
SasSwart Dec 17, 2024
7b2c259
make gen
SasSwart Dec 17, 2024
89177b2
fix dbauthz tests
SasSwart Dec 17, 2024
877517f
do the plumbing to get sql, api and frontend talking to one another
SasSwart Dec 23, 2024
0b3e0e6
rename migration
SasSwart Dec 23, 2024
6462cc2
move aggregation logic for GetUserStatusChanges into the SQL
SasSwart Dec 24, 2024
ccd0cdf
use window functions for efficiency
SasSwart Dec 24, 2024
12a274f
ensure we use the same time zone as the start_time param
SasSwart Dec 24, 2024
fcfd76e
ensure we use the same time zone as the start_time param
SasSwart Dec 24, 2024
7c0cade
make gen
SasSwart Dec 24, 2024
ecffc8b
update field names and fix tests
SasSwart Dec 24, 2024
f3a2ce3
exclude deleted users from the user status graph
SasSwart Dec 27, 2024
5067a63
GetUserStatusChanges now passes all querier tests
SasSwart Jan 2, 2025
254d436
renumber migrations
SasSwart Jan 2, 2025
3e86522
add partial fixture for CI
SasSwart Jan 3, 2025
2e49e4c
fix migration numbers
SasSwart Jan 3, 2025
ff59729
rename and document sql function
SasSwart Jan 3, 2025
b1ad074
make gen
SasSwart Jan 3, 2025
de4081f
Remove unwanted comments from the generated interface
SasSwart Jan 9, 2025
4de334f
review notes
SasSwart Jan 9, 2025
8fca0c5
make gen
SasSwart Jan 9, 2025
b06179c
remove frontend changes
SasSwart Jan 9, 2025
213b288
rename GetUserStatusCountsOverTime to GetUserStatusCounts
SasSwart Jan 9, 2025
9457ac8
fix tests
SasSwart Jan 9, 2025
63128a3
Update coderd/database/queries/insights.sql
SasSwart Jan 10, 2025
89f0a11
Provide basic durability against multiple deletions
SasSwart Jan 13, 2025
89ebab2
Provide basic durability against multiple deletions
SasSwart Jan 13, 2025
012f14c
populate the user_deleted_table
SasSwart Jan 13, 2025
c2efd97
formatting
SasSwart Jan 13, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Test GetUserStatusCountsByDay
  • Loading branch information
SasSwart committed Jan 9, 2025
commit eb6e2498855f34875003abc67c587f7024bf16e8
10 changes: 6 additions & 4 deletions coderd/database/dump.sql

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

13 changes: 7 additions & 6 deletions coderd/database/migrations/000279_user_status_changes.up.sql
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ CREATE TABLE user_status_changes (

COMMENT ON TABLE user_status_changes IS 'Tracks the history of user status changes';

CREATE INDEX idx_user_status_changes_user_id ON user_status_changes(user_id);
CREATE INDEX idx_user_status_changes_changed_at ON user_status_changes(changed_at);

INSERT INTO user_status_changes (
Expand All @@ -22,22 +21,24 @@ SELECT
FROM users
WHERE NOT deleted;

CREATE FUNCTION record_user_status_change() RETURNS trigger AS $$
CREATE OR REPLACE FUNCTION record_user_status_change() RETURNS trigger AS $$
BEGIN
IF OLD.status IS DISTINCT FROM NEW.status THEN
IF TG_OP = 'INSERT' OR OLD.status IS DISTINCT FROM NEW.status THEN
INSERT INTO user_status_changes (
user_id,
new_status
new_status,
changed_at
) VALUES (
NEW.id,
NEW.status
NEW.status,
NEW.updated_at
);
END IF;
RETURN NEW;
END;
$$ LANGUAGE plpgsql;

CREATE TRIGGER user_status_change_trigger
BEFORE UPDATE ON users
AFTER INSERT OR UPDATE ON users
FOR EACH ROW
EXECUTE FUNCTION record_user_status_change();
Loading