feat: added error boundary #1602
Conversation
|
Sorry for the drive-by comment on a merged PR, just happened across this and wondered if you had considered pre-filling out the email via E.g.: Just a thought, if this seems like a good idea I can open an issue about it. 👍🏻 |
|
@mafredri it's not merged yet! That's a good idea - I'll add this morning. |
Whoops!
|
| @@ -42,6 +42,7 @@ | |||
| "react": "17.0.2", | |||
| "react-dom": "17.0.2", | |||
| "react-router-dom": "6.3.0", | |||
| "sourcemapped-stacktrace": "1.1.11", | |||
There was a problem hiding this comment.
praise: Thanks for pinning this!
| </XServiceProvider> | ||
| <ThemeProvider theme={dark}> | ||
| <CssBaseline /> | ||
| <ErrorBoundary> |
There was a problem hiding this comment.
Praise: I love that the ErrorBoundary doesn't have to care about the XServiceProvider, it's good to keep these non-reliant on each other!
| </XServiceProvider> | ||
| <ThemeProvider theme={dark}> | ||
| <CssBaseline /> | ||
| <ErrorBoundary> |
There was a problem hiding this comment.
Praise: I love that the ErrorBoundary doesn't have to care about the XServiceProvider, it's good to keep these non-reliant on each other!
|
Nicely done 🌮 |
* added error boundary and error ui components * add body txt and standardize btn size * added story * feat: added error boundary closes #1013 * committing lockfile * added email body to help link
closes #1013