feat(cli): add provisioner list and provisioner jobs list #16030
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 3, 2025
5edf87e to
90a2e64
Compare
346ca29 to
ebaf498
Compare
90a2e64 to
90f19d1
Compare
ebaf498 to
ed828f6
Compare
180bf45 to
4dcb7cb
Compare
ed828f6 to
8bee6f5
Compare
4dcb7cb to
10475cc
Compare
8bee6f5 to
d76be47
Compare
mtojek
reviewed
Jan 7, 2025
|
|
||
| var got bytes.Buffer | ||
| inv, root := clitest.New(t, | ||
| "provisioners", |
There was a problem hiding this comment.
Is it provisioners or provisioner?
There was a problem hiding this comment.
The end goal is to show provisioners in the help for consistency with our other commands. I think you mentioned to move the rename from provisioner -> provisioners to a follow-up PR in #15940 so I implemented it here. Since it's aliased it doesn't really matter what the test calls out, so it'll be one less change in the follow-up PR.
| return cmd | ||
| } | ||
|
|
||
| func (r *RootCmd) provisionerList() *serpent.Command { |
johnstcn
reviewed
Jan 7, 2025
johnstcn
approved these changes
Jan 7, 2025
10475cc to
c1a8874
Compare
e4b4e2f to
d967f4b
Compare
555f4f3 to
33fc30d
Compare
d967f4b to
b1fbc82
Compare
8726bd9 to
3dcee5e
Compare
5633448 to
4bc3559
Compare
3dcee5e to
4c5b63b
Compare
a37b1bd to
c924457
Compare
4c5b63b to
b28a888
Compare
c924457 to
9525abd
Compare
b28a888 to
965d618
Compare
9525abd to
51f628c
Compare
965d618 to
737d4b1
Compare
51f628c to
1b40a44
Compare
737d4b1 to
ef7b2eb
Compare
b6eb60d to
8d5fca2
Compare
504fc08 to
d36df1a
Compare
dd49c08 to
0fd9aa7
Compare
Base automatically changed from
mafredri/feat-coderd-provisioner-jobs-list
to
main
January 20, 2025 09:18
d36df1a to
a8dd9a1
Compare
a8dd9a1 to
b9fc3a4
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack:
feat(cli): add provisioner list and provisioner jobs list
Closes #15191
Updates #15084
Supercedes #15940
(The column ordering in the tables is not ideal, I've created a follow-up issue for that: #16055.)