Skip to content

fix(cli/ssh): retry on autostart conflict #16058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 8, 2025
Merged

fix(cli/ssh): retry on autostart conflict #16058

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
df574a8
fix(cli/ssh): retry on autostart conflict
mafredri Jan 7, 2025
e5bee0b
cleanup test
mafredri Jan 7, 2025
042bd42
fix test racyness, add apimiddleware to coderdtest
mafredri Jan 8, 2025
331aa87
race
mafredri Jan 8, 2025
8fe33b8
try to fix test
mafredri Jan 8, 2025
7a703f0
handle unique violation in wsbuilder
mafredri Jan 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
handle unique violation in wsbuilder
  • Loading branch information
@mafredri
mafredri committed Jan 8, 2025
commit 7a703f0bcfa1db996b18cc3f17c133a43d4911be
4 changes: 4 additions & 0 deletions coderd/wsbuilder/wsbuilder.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -381,6 +381,10 @@ func (b *Builder) buildTx(authFunc func(action policy.Action, object rbac.Object
code := http.StatusInternalServerError
if rbac.IsUnauthorizedError(err) {
code = http.StatusForbidden
} else if database.IsUniqueViolation(err) {
// Concurrent builds may result in duplicate
// workspace_builds_workspace_id_build_number_key.
code = http.StatusConflict
}
return BuildError{code, "insert workspace build", err}
}
Expand Down
Loading